New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling save before load would crash Lovelace storage #20368

Merged
merged 1 commit into from Jan 24, 2019

Conversation

Projects
None yet
2 participants
@balloob
Copy link
Member

balloob commented Jan 24, 2019

Description:

In storage mode, Lovelace would crash if we call "save" before calling "load".

I am not sure how this can happen, but someone reported it 🤷‍♂️

STR:

  • Have no local Lovelace config
  • Open browser and browse to Lovelace panel
  • Restart Home Assistant
  • Take control of UI

Related issue (if applicable): https://community.home-assistant.io/t/0-86-new-lovelace-ui-and-zigbee-management-panel/93897/39?u=balloob

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Jan 24, 2019

@balloob balloob added this to the 0.86.1 milestone Jan 24, 2019

@balloob balloob merged commit 5580bec into dev Jan 24, 2019

6 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on lovelace-save-before-load at 93.106%
Details

@wafflebot wafflebot bot removed the in progress label Jan 24, 2019

@delete-merged-branch delete-merged-branch bot deleted the lovelace-save-before-load branch Jan 24, 2019

balloob added a commit that referenced this pull request Jan 24, 2019

@balloob balloob referenced this pull request Jan 24, 2019

Merged

0.86.1 #20369

mxworm added a commit to mxworm/home-assistant that referenced this pull request Jan 27, 2019

alandtse added a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment