Calling save before load would crash Lovelace storage #20368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: lovelace
small-pr
ghost
added
in progress
and removed
integration: lovelace
small-pr
balloob
added a commit
that referenced
this pull request
Jan 24, 2019
Merged
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Feb 12, 2019
kellerza
pushed a commit
to kellerza/home-assistant
that referenced
this pull request
Feb 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In storage mode, Lovelace would crash if we call "save" before calling "load".
I am not sure how this can happen, but someone reported it 🤷♂️STR:
Related issue (if applicable): https://community.home-assistant.io/t/0-86-new-lovelace-ui-and-zigbee-management-panel/93897/39?u=balloob
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: