Load/unload gpslogger entities correctly between component and platform #20448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
rohankapoorcom
added
platform: device_tracker.gpslogger
and removed
new-platform
remove-platform
integration: device_tracker
labels
|
Will github correctly detect the module move if that is done separately in one commit, and further changes applied after in another commit? |
rohankapoorcom
force-pushed
the
gpslogger-unload
branch
from
fcbc553
to
e367232
Compare
|
Looks like yes it will, just force pushed with it broken up that way. |
rohankapoorcom
force-pushed
the
gpslogger-unload
branch
from
e367232
to
b84eb33
Compare
|
Rebasing with |
This was referenced Jan 27, 2019
MartinHjelmare
requested changes
Jan 27, 2019
| return True | ||
|
|
||
|
|
||
| async def async_unload_entry(hass, entry): | ||
| """Unload a config entry.""" | ||
| hass.components.webhook.async_unregister(entry.data[CONF_WEBHOOK_ID]) | ||
|
|
||
| hass.async_create_task( |
There was a problem hiding this comment.
We can await the coroutine directly. We don't need to create a task.
|
Can be merged when build passes. |
fredrike
pushed a commit
to fredrike/home-assistant
that referenced
this pull request
Jan 30, 2019
…rm (home-assistant#20448) * Embed device_tracker in gpslogger * Load/unload gpslogger entities correctly between component and platform * Await the coroutine directly
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Relates to #20237.
This came out of a couple of discussions with @MartinHjelmare #20083 (comment) and #20079 (comment).
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: