Change connection test method of InfluxDB #20666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
platform: sensor.influxdb
small-pr
ghost
added
the
fabaff
changed the title
amelchio
approved these changes
Feb 1, 2019
|
Awesome. Thanks for pushing through! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
SHOW DIAGNOSTICS always needs admin privileges on influxdb. For the purposes of home-assistant this is too much.
Use 'SHOW SERIES' to have a relatively lightweight query which only needs READ privileges.
Related issue (if applicable): fixes #20378
Checklist:
tox. Your PR cannot be merged unless tests pass