New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change connection test method of InfluxDB #20666

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
4 participants
@magenbrot
Copy link
Contributor

magenbrot commented Feb 1, 2019

Description:

SHOW DIAGNOSTICS always needs admin privileges on influxdb. For the purposes of home-assistant this is too much.
Use 'SHOW SERIES' to have a relatively lightweight query which only needs READ privileges.

Related issue (if applicable): fixes #20378

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@wafflebot wafflebot bot added the in progress label Feb 1, 2019

@fabaff fabaff changed the title InfluxDB - change connection test method Change connection test method of InfluxDB Feb 1, 2019

@amelchio amelchio added this to the 0.87.0 milestone Feb 1, 2019

@amelchio amelchio merged commit aec8ad2 into home-assistant:dev Feb 1, 2019

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 93.044%
Details

@wafflebot wafflebot bot removed the in progress label Feb 1, 2019

@amelchio

This comment has been minimized.

Copy link
Member

amelchio commented Feb 1, 2019

Awesome. Thanks for pushing through!

balloob added a commit that referenced this pull request Feb 1, 2019

@balloob balloob referenced this pull request Feb 6, 2019

Merged

0.87.0 #20794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment