Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix person update on create #21355

Merged

Conversation

MartinHjelmare
Copy link
Member

@MartinHjelmare MartinHjelmare commented Feb 23, 2019

Description:

If home assistant is already running after start, a person that is created should be updated, and not wait for home assistant start to be updated.

Related issue (if applicable):
fixes #21334

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@andrewsayre andrewsayre merged commit 7143f4e into home-assistant:dev Feb 23, 2019
@ghost ghost removed the in progress label Feb 23, 2019
@MartinHjelmare MartinHjelmare deleted the fix-person-update-on-create branch February 23, 2019 21:39
balloob pushed a commit that referenced this pull request Feb 27, 2019
* Update tests to set correct hass running state

* Update person on adding person if hass is running

* Test creating person when hass is running
@balloob balloob mentioned this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Person Component Stuck On Unknown State Until It Is Updated Again Via UI
4 participants