Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update person variable name for readability #21528

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Update person variable name for readability #21528

merged 1 commit into from
Feb 28, 2019

Conversation

gorynychzmey
Copy link
Contributor

Description:

Updated variable name for readability

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Feb 28, 2019
@gorynychzmey gorynychzmey mentioned this pull request Feb 28, 2019
Merged
9 tasks
@MartinHjelmare MartinHjelmare changed the title Updated variable name for readability Updated person variable name for readability Feb 28, 2019
@MartinHjelmare MartinHjelmare changed the title Updated person variable name for readability Update person variable name for readability Feb 28, 2019
MartinHjelmare
MartinHjelmare approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fabaff fabaff merged commit 342ddbf into home-assistant:dev Feb 28, 2019
@ghost ghost removed the in progress label Feb 28, 2019
@balloob balloob added this to the 0.89.0 milestone Feb 28, 2019
balloob pushed a commit that referenced this pull request Mar 1, 2019
@gorynychzmey @balloob
Updated variable name for readability (#21528)
6f2dd21
@balloob balloob mentioned this pull request Mar 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed integration: person small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.89.0
Development

Successfully merging this pull request may close these issues.
5 participants
@gorynychzmey @MartinHjelmare @fabaff @balloob @homeassistant