Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloudhook support to SmartThings component #21905

Merged
merged 3 commits into from
Mar 11, 2019
Merged

Add cloudhook support to SmartThings component #21905

merged 3 commits into from
Mar 11, 2019

Conversation

andrewsayre
Copy link
Member

Description:

Adds cloudhook support through Home Assistant Cloud (Nabu Casa) to the SmartThings component. Highlights:

  • The default behavior for new integrations will be to use a cloudhook via Home Assistant Cloud (when logged in with a non-expired subscription) to receive push updates from the SmartThings cloud. This eliminates the need to expose the local Home Assistant to the internet and greatly simplifies setup.
  • Existing configured integrations will continue to function using the local webhook and must be removed in order to activate the new feature.

Pull request in home-assistant.io with documentation: home-assistant/home-assistant.io#8902

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned balloob Mar 11, 2019
@cgarwood cgarwood merged commit c401f35 into home-assistant:dev Mar 11, 2019
@ghost ghost removed the in progress label Mar 11, 2019
@andrewsayre andrewsayre deleted the feature-smartthings-cloud-webhook branch March 13, 2019 15:16
@balloob balloob mentioned this pull request Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants