New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Broadlink-wifi climate support #21962
Conversation
Services should go on broadlink domain as per #21465 |
PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({ | ||
vol.Required(CONF_HOST): cv.string, | ||
vol.Required(CONF_MAC): cv.string, | ||
vol.Required(CONF_FRIENDLY_NAME): cv.string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be careful with the naming here as we already have broadlink RM switch. And since the RM switch can be used as a climate (as I foresee a merge with the smartIr custom component), we might cause problems. Maybe rename the component to broadlink wifi, so we have a clear distinction? |
@tsvi: not sure about naming problem here. This components is made to control thermostat made by broadlink and rebranded. The smartIr custom components you speak about is a components made to control IR climate. It made it simple than using custom climate component, but do the same. I would prefer having this components named broadlink better than a component that provide the same uses cases as another. If my component should have another name, it will be named by it's brand name, so I'll need to create a least 3 component (breok, floureon, seesii) with the same code inside. |
Definitely was not imagining splitting it up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix bugs and mistypes
|
||
def set_advanced_config(self, advanced_conf): | ||
"""Set advanced configuration.""" | ||
self._device.set_advanced_config(self, advanced_conf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self._device.set_advanced_config(self, advanced_conf) | |
self._device.set_advanced_config(advanced_conf) |
"""Set automatic schedule.""" | ||
self._device.set_schedule(schedules) | ||
|
||
def set_advanced_config(self, advanced_conf): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def set_advanced_config(self, advanced_conf): | |
def set_advanced_conf(self, advanced_conf): |
Co-Authored-By: Francesco Antognazza <francesco.antognazza@gmail.com>
Co-Authored-By: Francesco Antognazza <francesco.antognazza@gmail.com>
Hello guys, I am very sorry for such a dummy question but I am completely new. Could you help me step by step how to install this platform? I am 1 day user of HA :) Shall I create a broadlink/climate.py in custom components or it does not work like that? Thank you very much for help! |
Please migrate / rebase to https://developers.home-assistant.io/blog/2019/07/03/climate-cleanup.html |
There hasn't been any movement here for a long time. I'll close now. We're trying to decrease our open PR buffer. Please open a new PR when ready to finish. |
Description:
The broadlink_thermostat climate platform is a thermostat implemented in Home Assistant. It is used to control wifi thermostat manufactured by broadlink, like Floureon Smart Wi-Fi Programmable Digital Touch Screen Thermostat, Beok TGT70WIFI-EP Smart Wifi Thermostat and SeeSii Programmable Thermostat Heating WiFi
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#8920
previous PR: #15363, #19223
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable ([example][ex-requir]).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.