-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for a wider variety of EnOcean devices #22052
Add support for a wider variety of EnOcean devices #22052
Conversation
1e2a328
to
4971963
Compare
I am back and the test errors (doh!) are fixed now |
2e2d072
to
a542ac8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This integration was made before we had our current standards in place. We should now adapt the integration to follow our current standards for the good of the integration.
My comments below should be read in that light.
e16e67c
to
0e61d11
Compare
0e61d11
to
da66f87
Compare
Thanks @MartinHjelmare for the reviews. I fixed everything (I believe). As discussed in Discord
|
Hi, i create a pull request with a mix off your code and another pull request : |
* Bump EnOcean version to 0.50 * Refactor components for more generic device handling * Move radio packet data interpretation to specific devices
da66f87
to
af6c824
Compare
This comment has been minimized.
This comment has been minimized.
Please don't squash commits after review has started. Sqaushing commits makes it harder for readers to track changes. |
Good job on the code! |
Breaking Change:
Theoretically, nothing should break. The default configuration is compatible with previous versions of the component. However, since I do not own all of the devices, I cannot guarantee it. I suspect that previous commiters @rubund and @NoUsername own some of the devices. Guys, if you read this, I would be very thankful if you could spend the time to review and test this PR.
Tested with:
Description:
This PR adds support for temperature sensors and humidity sensors. The telegram message is now closer to the officially documented messages, which in theory should support a wider variety of devices.
As a result of the new sensors and the more generic message parsing, a refactoring was necessary. The
enocean
package was updated, since newer versions can do the parsing for us, moving some complexity out of the component.The tests should make sure that the component still works for existing devices.
Note: I am away on an one week vacation, starting on the 16th. So take your time reviewing itRelated issue (if applicable): none
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8939
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: