Standardized temperature units for LCN sensors #22108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: lcn
small-pr
ghost
added
the
|
Can be merged when build passes. |
Danielhiversen
approved these changes
Mar 16, 2019
Merged
weaselshit
pushed a commit
to weaselshit/home-assistant
that referenced
this pull request
Apr 4, 2019
There are only TEMP_CELSIUS and TEMP_FAHRENHEIT, even though several components use Kelvins internally. home-assistant#22108 works around this, by handling Kelvins itself, while using own hardcoded string for Kelvins (incorrect, bt the way, see next commit for details). This commit adds TEMP_FAHRENHEIT constant that may be used by all components. LCN component will be updated in a separate commit.
weaselshit
pushed a commit
to weaselshit/home-assistant
that referenced
this pull request
Apr 4, 2019
This was addresssed partially in home-assistant#22108, but it uses wrong units for temperature in Kelvins. It must be just "K" (Kelvins, plural), not "°K" ("degrees of Kelvin"), it has been like that for over 50 years now: https://en.wikipedia.org/wiki/Kelvin#Usage_conventions. This commit ensures newly added TEMP_KELVIN constant from homeassistan.const is used instead of hardcoded incorrect string.
weaselshit
pushed a commit
to weaselshit/home-assistant
that referenced
this pull request
Apr 4, 2019
There are only TEMP_CELSIUS and TEMP_FAHRENHEIT, even though several components use Kelvins internally. home-assistant#22108 works around this, by handling Kelvins itself, while using own hardcoded string for Kelvins (incorrect, bt the way, see next commit for details). This commit adds TEMP_KELVINS constant that may be used by all components. LCN component will be updated in a separate commit.
weaselshit
pushed a commit
to weaselshit/home-assistant
that referenced
this pull request
Apr 4, 2019
This was addresssed partially in home-assistant#22108, but it uses wrong units for temperature in Kelvins. It must be just "K" (Kelvins, plural), not "°K" ("degrees of Kelvin"), it has been like that for over 50 years now: https://en.wikipedia.org/wiki/Kelvin#Usage_conventions. This commit ensures newly added TEMP_KELVINS constant from homeassistan.const is used instead of hardcoded incorrect string.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the standardized temperature units for Celsius and Fahrenheit for the LCN sensor compoenent.
Also the corresponding documentation has been updated.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8734
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example). - [ ] New dependencies are only imported inside functions that use them (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.