Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved exception handling and logging #22268

Merged
merged 1 commit into from Mar 22, 2019

Conversation

Projects
None yet
5 participants
@JeffLIrion
Copy link
Contributor

commented Mar 21, 2019

Description:

Catch RuntimeError exceptions. Don't log ADB command output if there isn't any.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
Improved exception handling and logging
Catch RuntimeError exceptions. Don't log ADB command output if there isn't any.

@cgarwood cgarwood merged commit b125514 into home-assistant:dev Mar 22, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.006%) to 93.668%
Details

@ghost ghost removed the in progress label Mar 22, 2019

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.