Add table with netgear_lte sensor units #22508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: netgear_lte
small-pr
ghost
assigned 
MartinHjelmare
approved these changes
Mar 28, 2019
Co-Authored-By: amelchio <amelchio@nogoto.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I am really trying to go for minimal PRs today. This one moves sensor name and unit of measurement into a table so the property methods can be defined only in the base sensor class. My next PR will expand the table with new sensors.
Building the table I realized that the unread sms count is a number so it should also have a unit.
Checklist:
tox. Your PR cannot be merged unless tests pass