Update ONVIF component to SUPPORT_STREAM #22569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
integration: onvif
small-pr
ghost
added
the
houndci-bot
reviewed
Mar 30, 2019
|
You need to fix lint errors else all good |
Remove extra spaces.
I think I did this now but I’m new to this PR thing. |
hunterjm
requested changes
Mar 31, 2019
There was a problem hiding this comment.
self._input starts as None and does not get set until obtain_input_uri is called in either async_camera_image or handle_async_mjpeg_stream is called at least once. This will mean the preload stream camera configuration will not work for this platform.
The setup_platform should be converted to async, and an async def initialize method or similar should be created to obtain the input URL as this component loads in order to work properly.
balloob
approved these changes
Mar 31, 2019
balloob
pushed a commit
that referenced
this pull request
Apr 1, 2019
* Update Onvif component to SUPPORT_STREAM * Update camera.py * Update camera.py * Update camera.py Remove extra spaces. * lookup URL when camera is added to hass and add extra guards
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add SUPPORT_STREAM to ONVIF component to allow streaming to the Google Assistant.
Related issue (if applicable): fixes #<0.91.0-b3
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: