-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimum/maximum to counter #22608
Merged
rohankapoorcom
merged 23 commits into
home-assistant:dev
from
rohankapoorcom:counter-min-max
Apr 18, 2019
Merged
Add minimum/maximum to counter #22608
rohankapoorcom
merged 23 commits into
home-assistant:dev
from
rohankapoorcom:counter-min-max
Apr 18, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed failing tests
- Fixed double quotes
- fixed failing test
rohankapoorcom
force-pushed
the
counter-min-max
branch
from
April 1, 2019 07:00
796708f
to
6ad2685
Compare
pvizeli
previously requested changes
Apr 1, 2019
balloob
approved these changes
Apr 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok to merge with last comment addressed
Thank you for pushing this foreward |
balloob
reviewed
Apr 16, 2019
rohankapoorcom
dismissed
pvizeli’s stale review
April 18, 2019 09:45
Miscommunication of the old named async_setup method
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
@spacemanspiff2007 originally submitted #17440 and #20319 to add a minimum/maximum to the counter component. Unfortunately, these PRs were never able to be driven to completion. I'd like to resubmit their work and take care of driving it to completion as this is functionality that I believe that the counter needs to support.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9086
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: