Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum/maximum to counter #22608

Merged
merged 23 commits into from
Apr 18, 2019

Conversation

rohankapoorcom
Copy link
Member

@rohankapoorcom rohankapoorcom commented Apr 1, 2019

Description:

@spacemanspiff2007 originally submitted #17440 and #20319 to add a minimum/maximum to the counter component. Unfortunately, these PRs were never able to be driven to completion. I'd like to resubmit their work and take care of driving it to completion as this is functionality that I believe that the counter needs to support.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9086

Example entry for configuration.yaml (if applicable):

counter:
  my_counter:
    initial: 0
    step : 1
    minimum: 0
    maximum: 10

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

pvizeli
pvizeli previously requested changes Apr 1, 2019
homeassistant/components/counter/__init__.py Outdated Show resolved Hide resolved
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge with last comment addressed

@spacemanspiff2007
Copy link

Thank you for pushing this foreward

@rohankapoorcom rohankapoorcom dismissed pvizeli’s stale review April 18, 2019 09:45

Miscommunication of the old named async_setup method

@rohankapoorcom rohankapoorcom merged commit f588fef into home-assistant:dev Apr 18, 2019
@rohankapoorcom rohankapoorcom deleted the counter-min-max branch April 18, 2019 10:02
@balloob balloob mentioned this pull request May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants