Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dict[key] for required config keys and keys with default values MQTT binary sensor #22829

Merged
merged 1 commit into from
Apr 7, 2019
Merged

Use dict[key] for required config keys and keys with default values MQTT binary sensor #22829

merged 1 commit into from
Apr 7, 2019

Conversation

emontnemery
Copy link
Contributor

Description:

Use dict[key] for required config keys and keys with default values.
Sort configuration schema.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@emontnemery emontnemery requested a review from a team as a code owner April 7, 2019 09:17
@ghost ghost assigned emontnemery Apr 7, 2019
@ghost ghost added the in progress label Apr 7, 2019
@github-actions
Copy link

github-actions bot commented Apr 7, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (mqtt) you are listed as a codeowner for? Thanks!

@codecov
Copy link

codecov bot commented Apr 7, 2019 •
edited
Loading

Codecov Report

Merging #22829 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #22829   +/-   ##
=======================================
  Coverage   93.83%   93.83%           
=======================================
  Files         448      448           
  Lines       36529    36529           
=======================================
  Hits        34276    34276           
  Misses       2253     2253
Impacted Files Coverage Δ
homeassistant/components/mqtt/binary_sensor.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6492809...83baec3. Read the comment docs.

@fabaff fabaff changed the title MQTT Binary sensor: Use dict[key] for required config keys and keys with default values. Use dict[key] for required config keys and keys with default values MQTT binary sensor Apr 7, 2019
@fabaff fabaff merged commit 58220a9 into home-assistant:dev Apr 7, 2019
@ghost ghost removed the in progress label Apr 7, 2019
@emontnemery emontnemery deleted the mqtt_cleanup_binary_sensor branch April 28, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees

@emontnemery emontnemery

Labels
cla-signed core integration: mqtt small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emontnemery @fabaff @homeassistant