-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Watson TTS (IBM Cloud) #23299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. It looks good.
Okay, all comments fixed and build is passing. Is it okay now? @awarecan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Is it going to be merged in the near future? The version I wrote in the documentation is the next one. :) |
|
||
CONF_URL = 'watson_url' | ||
CONF_APIKEY = 'watson_apikey' | ||
ATTR_CREDENTIALS = 'credentials' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could use that from const.py
by core and that helps user because all configs look the same.
* Adding Watson TTS (IBM Cloud) * Code review changes
Hi @rutkai, This platform is no longer working in latest HA release 0.100.x. See Issue 27722. Can you have a look to see if you think it can be fixed or if we have to consider removing it from HA? Thanks |
@Michel-Lapointe Please don't dig up older pull requests for discussions or bug reports. You've created an issue, which is the right way to go! Thanks 👍 |
Description:
This new component adds the possibility to connect Homeassistant with IBM Cloud (Watson) TTS service.
Pull request in home-assistant.io with documentation: home-assistant/home-assistant.io#9279
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
.If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
requirements
in the manifest (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.