Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Watson TTS (IBM Cloud) #23299

Merged
merged 2 commits into from
May 18, 2019
Merged

Adding Watson TTS (IBM Cloud) #23299

merged 2 commits into from
May 18, 2019

Conversation

rutkai
Copy link
Contributor

@rutkai rutkai commented Apr 22, 2019

Description:

This new component adds the possibility to connect Homeassistant with IBM Cloud (Watson) TTS service.

Pull request in home-assistant.io with documentation: home-assistant/home-assistant.io#9279

Example entry for configuration.yaml (if applicable):

tts:
  - platform: watson_tts
    watson_url: https://stream.watsonplatform.net/text-to-speech/api/v1/synthesize
    watson_apikey: your-generated-apikey

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@homeassistant
Copy link
Contributor

Hi @rutkai,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Contributor

@awarecan awarecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. It looks good.

.coveragerc Outdated Show resolved Hide resolved
homeassistant/components/watson_tts/tts.py Show resolved Hide resolved
homeassistant/components/watson_tts/tts.py Outdated Show resolved Hide resolved
homeassistant/components/watson_tts/tts.py Outdated Show resolved Hide resolved
homeassistant/components/watson_tts/tts.py Outdated Show resolved Hide resolved
homeassistant/components/watson_tts/tts.py Outdated Show resolved Hide resolved
@rutkai
Copy link
Contributor Author

rutkai commented May 3, 2019

Okay, all comments fixed and build is passing. Is it okay now? @awarecan

Copy link
Contributor

@awarecan awarecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@rutkai
Copy link
Contributor Author

rutkai commented May 13, 2019

Is it going to be merged in the near future? The version I wrote in the documentation is the next one. :)

@pvizeli pvizeli merged commit eebd094 into home-assistant:dev May 18, 2019

CONF_URL = 'watson_url'
CONF_APIKEY = 'watson_apikey'
ATTR_CREDENTIALS = 'credentials'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use that from const.py by core and that helps user because all configs look the same.

@balloob balloob mentioned this pull request Jun 4, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
* Adding Watson TTS (IBM Cloud)

* Code review changes
@Michel-Lapointe
Copy link

Hi @rutkai,

This platform is no longer working in latest HA release 0.100.x. See Issue 27722.

Can you have a look to see if you think it can be fixed or if we have to consider removing it from HA?

Thanks

@frenck
Copy link
Member

frenck commented Oct 29, 2019

@Michel-Lapointe Please don't dig up older pull requests for discussions or bug reports. You've created an issue, which is the right way to go! Thanks 👍

@home-assistant home-assistant locked as off-topic and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants