Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Philips js v0.0.8 #23462

Merged
merged 5 commits into from
Apr 29, 2019
Merged

Philips js v0.0.8 #23462

merged 5 commits into from
Apr 29, 2019

Conversation

elupus
Copy link
Contributor

@elupus elupus commented Apr 27, 2019

Description:

This fixes problems with certein versions of philips TV:s crashing when requesting source list: danielperna84/ha-philipsjs#12

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@elupus
Copy link
Contributor Author

elupus commented Apr 27, 2019

I might as well add myself as code owner for this component. I've been added as collaborator on upstream component.

@andrewsayre
Copy link
Member

I might as well add myself as code owner for this component. I've been added as collaborator on upstream component.

Feel free -- update the manifest and run script/hassfest.

Some TV's doesn't play nice with HTTP/1.1 connection
re-use.
@elupus elupus changed the title Philips js v0.0.7 Philips js v0.0.8 Apr 27, 2019
@cgarwood cgarwood merged commit b4a7980 into home-assistant:dev Apr 29, 2019
@elupus elupus deleted the philips_js_v2 branch May 2, 2019 10:55
@balloob balloob mentioned this pull request May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants