Continuous discovery of Sonos speakers #23484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
pvizeli
approved these changes
Apr 29, 2019
| assert hass.data[media_player.DATA_SONOS].uids == {'RINCON_test'} | ||
|
|
||
| entity = hass.data[media_player.DATA_SONOS].entities[0] | ||
| assert entity.unique_id == 'RINCON_test' |
There was a problem hiding this comment.
We should avoid asserting things about entitites directly. Primarily use the state of the entity to assert when the state holds what we need to test. For this case, we can check the unique_id by getting the entity registry entry for the entity, and assert that.
The idea is by avoiding using the entity directly in our tests, the code under test can be refactored without needing to change tests. This is very useful and will decrease risk of bugs.
There was a problem hiding this comment.
Thank you, I will keep that in mind.
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds a periodic discovery of Sonos so powered on speakers can be found without restarting Home Assistant.
The timestamp of the last succesful discovery is used to calculate the
availableproperty.We no longer allow adding "invisible" players (such as stereo slaves) because we cannot control them.
Finally, it turns out that we do not need to update
uidsbecause it is not used after #23385.Checklist:
tox.