Essent sensor

[TheLastProject]

Description:

Shows you the daily energy and gas usage per tariff.

Pull request in home-assistant.io: home-assistant/home-assistant.io#9351

Example entry for configuration.yaml (if applicable):

sensors:
  - platform: essent
    username: xxxxxx
    password: xxxxxx

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly (example).
• New dependencies have been added to requirements in the manifest (example).
• New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[TheLastProject]

I will add documentation in home-assistant.io once this passes tests :)

[dgomes]

Most of the code should move into it's own supporting library

[dgomes]

Thank you for pushing PyEssent, but more things could live there.

[amelchio]

This generally looks good 👍. Just a bunch of small comments. Let me know if I should elaborate some of them.

[TheLastProject]

Right now it crashes for non-existing tariffs:

019-04-29 19:26:47 ERROR (MainThread) [homeassistant.components.sensor] essent: Error on device update!                                                                   
Traceback (most recent call last):                                                                                                                                         
  File "/home/sylvia/Projects/Forks/home-assistant/homeassistant/helpers/entity_platform.py", line 261, in _async_add_entity                                               
    await entity.async_device_update(warning=False)                                                                                                                        
  File "/home/sylvia/Projects/Forks/home-assistant/homeassistant/helpers/entity.py", line 377, in async_device_update                                                      
    await self.hass.async_add_executor_job(self.update)                                                                                                                    
  File "/usr/lib64/python3.7/concurrent/futures/thread.py", line 57, in run                                                                                                
    result = self.fn(*self.args, **self.kwargs)                                                                                                                            
  File "/home/sylvia/Projects/Forks/home-assistant/homeassistant/components/essent/sensor.py", line 89, in update                                                          
    self._meter_unit = data['values']['LVR'][self._tariff]['unit']                                                                                                         
KeyError: 'H'                                                                                                                                                              

Is there a cleaner way to "uninitialize" devices like this for tariffs the user doesn't have? Or should I just catch this and not set the values, leaving the unused device "empty" instead?

[TheLastProject]

Well, this is working well! 9f343a7 may be a bit ugly though. Any suggestions for a cleaner way?

[TheLastProject]

Ignore my rambling, I got it pretty tidy now I think. Please tell me if there's anything left you are unhappy with :)

[dgomes]

LGTM :)

[dgomes]

EssentMeter uses SCAN_INTERVAL to only update every hour, why is EssenBase.update() Throttle to 30min ?

I must now agree with @amelchio initial comment that EssenBase looks redundant, you could get away with just create_meters.

[TheLastProject]

EssentMeter uses SCAN_INTERVAL to only update every hour, why is EssenBase.update() Throttle to 30min ?

I figured that putting them both on one hour could, depending on when the timers would run, cause it to skip it every now and then? Like, race condition stuff? I could use the same time for both though if you'd prefer.

[dgomes]

EssentMeter.update() is only called by the update, I see no need to Throttle it (maybe I'm missing something)

[TheLastProject]

Well, multiple meters that will all call it? Because the EssentBase update updates all the meter data together, it could cause several calls to the same API endpoint in quick succession.

[amelchio]

Awesome! Just nitpicking left ...

[TheLastProject]

So, I think this is it. Code works fine :)

[amelchio]

Yes, this looks great now. Amazing to see you pick up so fast 🎉. I hope you also like the result.

[TheLastProject]

Yeah, it's a lot better than the initial commit. Thank you for your patience and guidance, @amelchio and @dgomes :)