Add Minio component

homeassistant/components/minio/__init__.py

@@ -8,7 +8,7 @@
 import voluptuous as vol
 
 from homeassistant.const import EVENT_HOMEASSISTANT_START, \
-    EVENT_HOMEASSISTANT_STOP
+    EVENT_HOMEASSISTANT_STOP, CONF_FILE_PATH
 import homeassistant.helpers.config_validation as cv
 
 from .minio_helper import create_minio_client, MinioEventThread
@@ -27,6 +27,9 @@
 CONF_LISTEN_SUFFIX = 'suffix'
 CONF_LISTEN_EVENTS = 'events'
 
+CONF_BUCKET = 'bucket'
+CONF_KEY = 'key'
+
 DEFAULT_LISTEN_PREFIX = ''
 DEFAULT_LISTEN_SUFFIX = '.*'
 DEFAULT_LISTEN_EVENTS = 's3:ObjectCreated:*'
@@ -60,12 +63,12 @@
 }, extra=vol.ALLOW_EXTRA)
 
 BUCKET_KEY_SCHEMA = vol.Schema({
-    vol.Required('bucket'): cv.template,
-    vol.Required('key'): cv.template,
+    vol.Required(CONF_BUCKET): cv.template,
+    vol.Required(CONF_KEY): cv.template,
 })
 
 BUCKET_KEY_FILE_SCHEMA = BUCKET_KEY_SCHEMA.extend({
-    vol.Required('file_path'): cv.template,
+    vol.Required(CONF_FILE_PATH): cv.template,
 })
 
 
@@ -135,9 +138,9 @@ def _render_service_value(service, key):
 
     def put_file(service):
         """Upload file service."""
-        bucket = _render_service_value(service, 'bucket')
-        key = _render_service_value(service, 'key')
-        file_path = _render_service_value(service, 'file_path')
+        bucket = _render_service_value(service, CONF_BUCKET)
+        key = _render_service_value(service, CONF_KEY)
+        file_path = _render_service_value(service, CONF_FILE_PATH)
 
         if not hass.config.is_allowed_path(file_path):
             _LOGGER.error('Invalid file_path %s', file_path)
@@ -147,9 +150,9 @@ def put_file(service):
 
     def get_file(service):
         """Download file service."""
-        bucket = _render_service_value(service, 'bucket')
-        key = _render_service_value(service, 'key')
-        file_path = _render_service_value(service, 'file_path')
+        bucket = _render_service_value(service, CONF_BUCKET)
+        key = _render_service_value(service, CONF_KEY)
+        file_path = _render_service_value(service, CONF_FILE_PATH)
 
         if not hass.config.is_allowed_path(file_path):
             _LOGGER.error('Invalid file_path %s', file_path)
@@ -159,8 +162,8 @@ def get_file(service):
 
     def remove_file(service):
         """Delete file service."""
-        bucket = _render_service_value(service, 'bucket')
-        key = _render_service_value(service, 'key')
+        bucket = _render_service_value(service, CONF_BUCKET)
+        key = _render_service_value(service, CONF_KEY)
 
         minio_client.remove_object(bucket, key)
 
@@ -199,13 +202,13 @@ def run(self):
             if event is None:
                 break
 
-            _, file_name = os.path.split(event['key'])
+            _, file_name = os.path.split(event[CONF_KEY])
 
             _LOGGER.debug(
                 'Sending event %s, %s, %s',
                 event['event_name'],
-                event['bucket'],
-                event['key']
+                event[CONF_BUCKET],
+                event[CONF_KEY]
             )
             self._hass.bus.fire(DOMAIN, {
                 'file_name': file_name,

homeassistant/components/minio/minio_helper.py

@@ -57,8 +57,7 @@ def get_minio_notification_response(
         'suffix': suffix,
         'events': events,
     }
-    # noinspection PyProtectedMember
-    # pylint: disable=W0212
+    # pylint: disable=protected-access
     return minio_client._url_open(
         'GET',
         bucket_name=bucket_name,
@@ -165,6 +164,8 @@ def run(self):
             except json.JSONDecodeError:
                 response.close()
             except AttributeError:
+                # When response is closed, iterator will fail to access
+                # the underlying socket descriptor.
                 break
 
             # Wait before attempting to connect again.
@@ -180,7 +181,7 @@ def _iterate_event_stream(self, event_stream_it, minio_client):
                     )
                 # Fail gracefully. If for whatever reason this stops working,
                 # it shouldn't prevent it from firing events.
-                # pylint: disable=W0703
+                # pylint: disable=broad-except
                 except Exception as error:
                     _LOGGER.error(
                         'Failed to generate presigned url: %s',

tests/components/minio/test_minio.py

@@ -26,13 +26,14 @@ def minio_client_fixture():
         yield minio_client_mock
 
 
-@pytest.fixture(name="minio_event_response")
-def minio_event_response_fixture():
+@pytest.fixture(name="minio_client_event")
+def minio_client_event_fixture():
     """Patch helper function for minio notification stream."""
     with patch(
-        'homeassistant.components.minio'
-        '.minio_helper.get_minio_notification_response'
-    ) as get_notification_response_mock:
+            'homeassistant.components.minio.minio_helper.Minio'
+    ) as minio_mock:
+        minio_client_mock = minio_mock.return_value
+
         response_mock = MagicMock()
         stream_mock = MagicMock()
 
@@ -43,9 +44,9 @@ def minio_event_response_fixture():
         ]
 
         response_mock.stream.return_value = stream_mock
-        get_notification_response_mock.return_value = response_mock
+        minio_client_mock._url_open.return_value = response_mock
 
-        yield get_notification_response_mock
+        yield minio_client_mock
 
 
 async def test_minio_services(hass, caplog, minio_client):
@@ -117,9 +118,9 @@ async def test_minio_services(hass, caplog, minio_client):
     minio_client.reset_mock()
 
 
-async def test_minio_listen(hass, caplog, minio_client, minio_event_response):
+async def test_minio_listen(hass, caplog, minio_client_event):
     """Test minio listen on notifications."""
-    minio_client.presigned_get_object.return_value = 'http://url'
+    minio_client_event.presigned_get_object.return_value = 'http://url'
 
     events = []