Add debug prints to sun #23598
Merged
Add debug prints to sun #23598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
core
integration: sun
small-pr
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
Closed
balloob
reviewed
May 2, 2019
| @@ -120,15 +120,20 @@ def point_in_time_listener(self, now): | |||
| """Run when the state of the sun has changed.""" | |||
| self.update_sun_position(now) | |||
| self.update_as_of(now) | |||
| self.async_schedule_update_ha_state() | |||
| self.async_write_ha_state() | |||
| state = self.hass.states.get('sun.sun') | |||
There was a problem hiding this comment.
Don't do this. Entities should not add a dependency on their own state in the state machine. All the info should be there locally.
There was a problem hiding this comment.
yeah, this was really lazy..
Will fix!
balloob
approved these changes
May 7, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add debug prints to sun.
Intended to aid debugging of #11985 and similar issues
Checklist:
tox. Your PR cannot be merged unless tests pass