Don't pass in loop #23984
Merged
Don't pass in loop #23984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
requested review from
amelchio,
andrey-git,
emlove,
awarecan,
bachya,
dgomes,
fabaff,
Jc2k,
Kane610,
kellerza,
robbiet480,
rytilahti,
syssi and
a team
as code owners
Kane610
reviewed
May 19, 2019
|
Better regexp: Pretty much all the ones that aren't the last argument are to external libraries. There's a few calls to the |
wolph
reviewed
May 26, 2019
| else: | ||
| reader_factory = partial( | ||
| create_dsmr_reader, config[CONF_PORT], config[CONF_DSMR_VERSION], | ||
| update_entities_telegram, loop=hass.loop) |
There was a problem hiding this comment.
This breaks the dsmr module. Should this be replaced with loop=asyncio.get_event_loop()?
There was a problem hiding this comment.
Reinstating this should be a temporary fix. The loop argument should always be optional (since it's going to go away anyway).
There was a problem hiding this comment.
@smurfix: it's actually caused by an upstream bug, as soon as that's fixed we can fix this properly: ndokter/dsmr_parser#36
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
First pass removing passing loop around.
Related issue (if applicable): home-assistant/architecture#238
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: