Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for boost mode in Homematicip climate #23999

Closed
wants to merge 5 commits into from

Conversation

karlkar
Copy link
Contributor

@karlkar karlkar commented May 19, 2019

Description:

Homematic IP Cloud component misses support for boost mode that allows to quickly heaten up the room.
This PR presents an implementation for this function.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Homematic IP Cloud component misses support for boost mode that allows to quickly heaten up the room.
This PR presents an implementation for this function.
@karlkar
Copy link
Contributor Author

karlkar commented May 20, 2019

Is this build failure my fault?

@SukramJ
Copy link
Contributor

SukramJ commented May 20, 2019

Hi @karlkar,
thanks for your contribution to HA, and especially to this component.
You should be aware that there were approches in the past to add boost state to this component.
You should have a look at these closed PRs by @mxworm: #14388 and #19861.

There was also a longer conversation in the architecture repo about an Architectural Review of the climate entity.
As a result of this discussion @pvizeli is currently taking care about the re-design/implementation in PR #23899.
Afterwards BOOST could be implemented also for HmIP Cloud.

BR

@pvizeli
Copy link
Member

pvizeli commented May 22, 2019

Close that because need complete new way with -> #23899

@pvizeli pvizeli closed this May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants