Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abbreviation for light template variable names #24336

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Add abbreviation for light template variable names #24336

merged 1 commit into from
Jun 6, 2019

Conversation

bieniu
Copy link
Member

@bieniu bieniu commented Jun 6, 2019

Description:

Add abbreviation for command_on_template, command_off_template, state_template, brightness_template, red_template, green_template, blue_template, effect_template using in MQTT Light component (schema: template).

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9573

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@bieniu bieniu requested a review from a team as a code owner June 6, 2019 07:20
@ghost
Copy link

ghost commented Jun 6, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (mqtt) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@fabaff fabaff merged commit 3b4a9a3 into home-assistant:dev Jun 6, 2019
@bieniu bieniu deleted the patch-1 branch June 6, 2019 16:41
@balloob balloob mentioned this pull request Jun 26, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants