Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add support for ZHA door locks #2 #24344
Adds support for ZHA door locks. Supports lock and unlock.
This is my second try, maybe it will work this time. Last try is here: #24126
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
If the code does not interact with devices:
third param of a
I'm personally (cause that how I learnt it from
and since no args were given to command, no *args to check. HA tests should not be concerned that
Also, specifically for this case IMO it is better to mock the
Great, thanks for your help. Yes this is working fine. If you are okay with just doing that I will commit these changes.
This seems like a bigger change to how the ZHA tests are done, probably should be a different pull request at least?
While I do appreciate the tests, they certainly make for better code. But man they take hours to run and are so cumbersome to use. And while I did figure out how to run a limited test it seems that it doesn't really catch things. Is it even possible to run codecov locally?
Jun 7, 2019
12 of 13 checks passed
@presslab-us Does the zha component description/documentation in zha.markdown need updating?
Compare to zwave component description/documentation: