Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ZHA door locks #24126

Closed
wants to merge 163 commits into from
Closed

Add support for ZHA door locks #24126

wants to merge 163 commits into from

Conversation

presslab-us
Copy link
Contributor

@presslab-us presslab-us commented May 26, 2019 •
edited

Description:

Adds support for ZHA door locks. Supports lock and unlock.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9522

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

pvizeli and others added 20 commits May 17, 2019 06:33
@pvizeli @balloob
Fix Hassio-version for Azure Pipelines (#23895)
5dc841e
@balloob
Update Honeywell warning (#23913)
8d2a784
@elupus @balloob
Switch media player to SWITCH type (#23914)
6030e41 
MEDIA device type is being rejected by google now.
@karlkar @balloob
Fix problem with cameras that don't support time (#23924)
58f28f1 
Some onvif cameras don't support Date management. In that case None is returned and script crashes when trying to obtain date
@balloob
Bumped version to 0.93.1
e122226
@balloob
Merge pull request #23932 from home-assistant/rc
7818c98 
0.93.1
@presslab-us
Add support for DoorLock cluster
489c60d
@presslab-us
Add test for zha lock
7756315
@presslab-us
Change lock_state report to REPORT_CONFIG_IMMEDIATE
38ba5dd
@pvizeli @balloob
Fix auto version update Hass.io (#23935)
c5bd6b3
@ludeeus @balloob
Bump pytraccar (#23939)
41b7f5a
@ludeeus @balloob
Fixes issue with multiple alerts (#23945)
f6e6c21 
* Fixes issue with multiple alerts

* Adds missing new line

* Remove whitespace
@aerialls @balloob
Setup integration dependencies before loading it (#23957)
99c49c0
@cyrosy @balloob
Make Discord payload data key not required (#23964)
bf910ef
@Danielhiversen @balloob
upgrade broadlink library (#23966)
70c5c82
@balloob
Bumped version to 0.93.2
8d0b158
@balloob
Merge pull request #24047 from home-assistant/rc
77f595c 
0.93.2
@presslab-us
Update channel command wrapper to return the entire result
92c8f18 
This allows for return values other than result[1]
@presslab-us
Fix tests
35845e4
@presslab-us
Fix lint
da74bda
@homeassistant
Copy link
Contributor

Hi @presslab-us,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@ghost ghost assigned Adminiuga and dmulcahey May 26, 2019
@ghost
Copy link

ghost commented May 26, 2019

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@dmulcahey
Use node descriptor from Zigpy for ZHA (#24316)
ae1bcd5 
* use zigpy node descriptor

* cleanup
@dmulcahey dmulcahey closed this Jun 6, 2019
@dmulcahey dmulcahey reopened this Jun 6, 2019
@dmulcahey
Copy link
Contributor

dmulcahey commented Jun 6, 2019 •
edited

@presslab-us trying to figure out what to do w/ this... maybe rebase the PR off of current dev. That will force everything to run again (grasping here :) )?

@presslab-us
Copy link
Contributor Author

Looks like it's all screwed up now, sigh. I'll just close this.

@presslab-us presslab-us closed this Jun 6, 2019
@dmulcahey
Copy link
Contributor

You can reset it and try again... ping me on discord if you want help. Same handle

@presslab-us presslab-us mentioned this pull request Jun 6, 2019
Merged
9 tasks
@presslab-us
Copy link
Contributor Author

It looks fine on my repo. I created a new pull request here: #24344. Crossing fingers that it passes the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adminiuga Adminiuga Awaiting requested review from Adminiuga Adminiuga is a code owner

@dmulcahey dmulcahey Awaiting requested review from dmulcahey dmulcahey is a code owner

@amelchio amelchio Awaiting requested review from amelchio

@bachya bachya Awaiting requested review from bachya bachya is a code owner

@balloob balloob Awaiting requested review from balloob balloob is a code owner

@Danielhiversen Danielhiversen Awaiting requested review from Danielhiversen Danielhiversen is a code owner

@dgomes dgomes Awaiting requested review from dgomes dgomes is a code owner

@frenck frenck Awaiting requested review from frenck frenck is a code owner

@Jc2k Jc2k Awaiting requested review from Jc2k Jc2k is a code owner

@Kane610 Kane610 Awaiting requested review from Kane610 Kane610 is a code owner

@OttoWinter OttoWinter Awaiting requested review from OttoWinter OttoWinter is a code owner

@robbiet480 robbiet480 Awaiting requested review from robbiet480

@rytilahti rytilahti Awaiting requested review from rytilahti rytilahti is a code owner

@scop scop Awaiting requested review from scop scop is a code owner

Assignees

@dmulcahey dmulcahey

@Adminiuga Adminiuga

Labels
cla-signed has-tests integration: zha new-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet