Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix locative device update #24744

Merged
merged 2 commits into from
Jun 25, 2019
Merged

Fix locative device update #24744

merged 2 commits into from
Jun 25, 2019

Conversation

MartinHjelmare
Copy link
Member

@MartinHjelmare MartinHjelmare commented Jun 25, 2019 •
edited
Loading

Breaking Change:

N/A

Description:

  • Add a locative test where two devices are updated after one another.
  • Fix locative updating all devices to the same state, when one device is updated.

Related issue (if applicable):
fixes #24674

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@MartinHjelmare
Add a test for two devices
223c2ec
@MartinHjelmare
Fix locative updating all devices
8ab92f0 
* Add a guard clause that checks if correct device is passed.
@MartinHjelmare MartinHjelmare added this to the 0.95.0 milestone Jun 25, 2019
@balloob balloob merged commit d4fc22a into dev Jun 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-locative-device-update branch June 25, 2019 03:00
balloob pushed a commit that referenced this pull request Jun 25, 2019
@MartinHjelmare @balloob
Fix locative device update (#24744)
8830054 
* Add a test for two devices

* Fix locative updating all devices

* Add a guard clause that checks if correct device is passed.
@balloob balloob mentioned this pull request Jun 26, 2019
Merged
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
@MartinHjelmare @alandtse
Fix locative device update (home-assistant#24744)
f708d10 
* Add a test for two devices

* Fix locative updating all devices

* Add a guard clause that checks if correct device is passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed has-tests integration: locative small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.95.0
Development

Successfully merging this pull request may close these issues.

Locative sets other devices location to be the same as the first one that changes location
3 participants
@MartinHjelmare @balloob @homeassistant