Fix script/translations_develop launch + clean some unused error i18n #25459
Conversation
Quentame
requested review from
Adminiuga,
andrewsayre,
dmulcahey,
elupus,
frenck and
robbiet480
as code owners
ghost
assigned 
|
Hey there @andrewsayre, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
|
Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
|
Hey there @elupus, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
|
Hey there @fredrike, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
|
Hey there @frenck, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
|
Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
|
Our files are managed by running Why would we change the property order in |
|
Hi @balloob I've change order on heos, twentemilieu, UPNP, Vesync and ZHA strings.json because I though it should be on the same as generated but I'm wrong, reverting this. The purpose of this PR is tho fix this : while launching script/translations_develop on clean dev, that's all. |
Quentame
force-pushed
the
fix-translations
branch
from
67f8103
to
4b6f65a
Compare
| "step": {}, | ||
| "error": {}, | ||
| "abort": {} | ||
| "title": "Arcam FMJ" |
There was a problem hiding this comment.
we should remove this whole file, there is no config flow.
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh I guess it's correct. It just only works with import and not with user facing config flow. my bad.
There was a problem hiding this comment.
Can we resolve this @balloob ?
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "config": { | |||
| "abort": { | |||
| "all_configured": "TelldusLive is already configured", | |||
There was a problem hiding this comment.
Have the config-flow for tellduslive been updated with this?
There was a problem hiding this comment.
In all tellduslive/.translations/[LANG].json, this property is contained.
I've picked this one from the en.json file.
So I guess yes, but didn't look at it.
There was a problem hiding this comment.
AFAIK Ait is not used in the flow so this key should not be there.
There was a problem hiding this comment.
Okey, so I remove the key for all langs
There was a problem hiding this comment.
Can we resolve this @fredrike ?
|
First, there is #25575 ... |
Quentame
force-pushed
the
fix-translations
branch
from
4b6f65a
to
34be91a
Compare
MartinHjelmare
changed the title
|
Please rebase and solve the merge conflicts. |
Quentame
force-pushed
the
fix-translations
branch
from
34be91a
to
653a086
Compare
|
Done @MartinHjelmare |
|
Ok @balloob ? |
|
When I run |
|
Will look at it today or tomorrow |
Quentame
force-pushed
the
fix-translations
branch
from
653a086
to
7fb7e77
Compare
Quentame
force-pushed
the
fix-translations
branch
from
7fb7e77
to
e72e8d9
Compare
|
@balloob : I don't see what's wrong, are you on the last version of my branch ? |
|
I think it was because the key still existed in Lokalise. I have now removed it from there and will go ahead and merge this. Great work 👍 |
Breaking Change:
Nothing
Description:
Fixing translation files when going to develop and launch
script/translations_develop:Checklist:
tox. Your PR cannot be merged unless tests pass