Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more states for state_topic mqtt cover #25698

Closed

Conversation

@MarcHagen
Copy link

commented Aug 4, 2019

Description:

Some default home-assistant like open, opening, close, closing
And one extra named stopped, indicating stopped while moving.

Related issue (if applicable): noop

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10053

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Added more states for state_topic in mqtt cover
Some default home-assistant like open,opening,close,closing
And one extra named stopped, indicating stopped while moving.

@MarcHagen MarcHagen requested a review from home-assistant/core as a code owner Aug 4, 2019

@homeassistant

This comment has been minimized.

Copy link

commented Aug 4, 2019

Hi @TakeMeNL,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@ghost

This comment has been minimized.

Copy link

commented Aug 4, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (cover) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@ghost

This comment has been minimized.

Copy link

commented Aug 4, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (mqtt) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@project-bot project-bot bot added this to Needs review in Dev Aug 4, 2019

@homeassistant homeassistant added cla-signed and removed cla-needed labels Aug 4, 2019

Dev automation moved this from Needs review to Review in progress Aug 4, 2019

@@ -255,6 +258,11 @@ def is_closing(self):
"""Return if the cover is closing or not."""
pass

@property
def is_stopped(self):

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Aug 4, 2019

Member

Changes to an entity model, like cover, needs to first be approved in an issue in our architecture repo.

https://developers.home-assistant.io/docs/en/entity_index.html#changing-the-entity-model

This comment has been minimized.

Copy link
@MarcHagen

MarcHagen Aug 5, 2019

Author

Oke i have opened a proposal home-assistant/architecture#269

@MartinHjelmare MartinHjelmare changed the title Added more states for state_topic mqtt cover Add more states for state_topic mqtt cover Aug 9, 2019

@balloob

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Will close this PR while the architecture issue is being discussed.

@balloob balloob closed this Aug 9, 2019

Dev automation moved this from Review in progress to Cancelled Aug 9, 2019

@lock lock bot locked and limited conversation to collaborators Aug 10, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.