Add more states for state_topic mqtt cover #25698
Conversation
Some default home-assistant like open,opening,close,closing And one extra named stopped, indicating stopped while moving.
probot-home-assistant
bot
added
core
has-tests
integration: cover
integration: mqtt
labels
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
| @@ -255,6 +258,11 @@ def is_closing(self): | |||
| """Return if the cover is closing or not.""" | |||
| pass | |||
|
|
|||
| @property | |||
| def is_stopped(self): | |||
There was a problem hiding this comment.
Changes to an entity model, like cover, needs to first be approved in an issue in our architecture repo.
https://developers.home-assistant.io/docs/en/entity_index.html#changing-the-entity-model
There was a problem hiding this comment.
Oke i have opened a proposal home-assistant/architecture#269
MartinHjelmare
changed the title
|
Will close this PR while the architecture issue is being discussed. |
Description:
Some default home-assistant like
open,opening,close,closingAnd one extra named
stopped, indicating stopped while moving.Related issue (if applicable): noop
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10053
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: