Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update homekit_controller import style to be consistent #25940

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

Jc2k
Copy link
Member

@Jc2k Jc2k commented Aug 14, 2019

Description:

This is just a change to be consistent with binary_sensor.py and sensor.py which both recently switched their imports to be at the top now we have manifest.json.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@MartinHjelmare
Copy link
Member

We have flaky tests on dev from another integration at the moment. That's why CI is failing.

@balloob balloob merged commit 002f74c into home-assistant:dev Aug 14, 2019
@lock lock bot locked and limited conversation to collaborators Aug 15, 2019
@Jc2k Jc2k deleted the homekit_controller_import_moves branch December 7, 2019 09:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants