Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update homekit_controller import style to be consistent #25940

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@Jc2k
Copy link
Contributor

commented Aug 14, 2019

Description:

This is just a change to be consistent with binary_sensor.py and sensor.py which both recently switched their imports to be at the top now we have manifest.json.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

Dev automation moved this from Needs review to Reviewer approved Aug 14, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

We have flaky tests on dev from another integration at the moment. That's why CI is failing.

@balloob balloob merged commit 002f74c into home-assistant:dev Aug 14, 2019

7 of 10 checks passed

CI Build #20190814.11 had test failures
Details
CI (Tests PyTest Python36) Tests PyTest Python36 failed
Details
CI (Tests PyTest Python37) Tests PyTest Python37 failed
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.

Dev automation moved this from Reviewer approved to Done Aug 14, 2019

@lock lock bot locked and limited conversation to collaborators Aug 15, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
4 participants
You can’t perform that action at this time.