Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config entry options support to deCONZ #26049

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@Kane610
Copy link
Contributor

commented Aug 18, 2019

Breaking Change:

Description:

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Aug 18, 2019

@Kane610 Kane610 self-assigned this Aug 19, 2019

@balloob
Copy link
Member

left a comment

Beautiful ! <3

Dev automation moved this from Needs review to Reviewer approved Aug 19, 2019

@balloob balloob merged commit e41c002 into home-assistant:dev Aug 19, 2019

10 checks passed

CI Build #20190818.43 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.

Dev automation moved this from Reviewer approved to Done Aug 19, 2019

@Kane610

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

Woo-hoo 💃🕺

@Kane610 Kane610 deleted the Kane610:deconz-config-entry-options branch Aug 19, 2019

@lock lock bot locked and limited conversation to collaborators Aug 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
3 participants
You can’t perform that action at this time.