Fix torque degree char #26183
Merged
Fix torque degree char #26183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
small-pr
MartinHjelmare
requested changes
Aug 31, 2019
|
|
||
| temp_unit = data[key] | ||
| if "\\xC2\\xB0" in temp_unit: | ||
| temp_unit = temp_unit.replace("\\xC2\\xB0", "°") |
There was a problem hiding this comment.
Isn't it possible to solve this by applying the correct encoding at some point in the flow after receiving the request?
There was a problem hiding this comment.
To be honest, I am not a proficient python coder, and this was the only way i was able to correct the units. The posted url is a query string with these characters. Seeing as how this was left effectively broken, I tinkered until I found a working solution. I'm all ears if you have a cleaner solution.
There was a problem hiding this comment.
Can you check if the following would fix your issue:
units[pid] = data[key].decode("utf-8")
MartinHjelmare
added
the
second-opinion-wanted
|
Do we have another suggestion or should we merge? |
balloob
approved these changes
Sep 18, 2019
MartinHjelmare
removed
the
second-opinion-wanted
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
None
Description:
When sensors are added to home-assistant, those with degree symbols are shown as
\\xC2\\xB0instead of°. This PR corrects the symbol.Related issue (if applicable):
None. Created a PR instead of issue. :-)
Pull request with documentation for home-assistant.io (if applicable):
None
Example entry for
configuration.yaml(if applicable):Nothing changes
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: