Jewish calendar binary sensor

[tsvi]

Breaking Change:

Change in configuration.yaml

sensor:
  - platform: jewish_calendar
    sensors:
       - date
       - ...

To

jewish_calendar:

Automations based on sensor.issur_melacha_in_effect comparison to True/False need to be updated to use binary_sensor.issur_melacha_in_effect on and off states.

Explanation

• Move Jewish calendar sensor to its own platform
• Split sensors into sensors and binary sensors
• Removal of the "sensors" key, following ADR003 removing data selectors, instead show all of the sensors.

The issur_melacha_in_effect was supposed to be a binary sensor. I wasn't aware of the distinction back when I first developed this integration. This fixes this issue by creating a new platform, supporting both types of sensors.

Description:

Make Jewish calendar its own platform with two types of sensors: sensor and binary sensor. In a future PR I plan to split the sensor furthermore in data and time related so that I can provide datetime attributes in the same fashion as the date sensor. This will provide easier ways of writing automations.

Related issue (if applicable): fixes #20315
As part of this change, I implemented @MartinHjelmare suggestion for testing the components,

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10231

Example entry for configuration.yaml (if applicable):

jewish_calendar:
  language: hebrew
  diaspora: False

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[tsvi]

Finally got all the tests to pass. @MartinHjelmare any more fixes necessary?

[MartinHjelmare]

Looks good!

[tsvi]

Fixed the imports as requested

[tsvi]

I think we need a breaking change label here.

[MartinHjelmare]

Please add to the breaking change paragraph what the user needs to do to cope with the breaking change.

[tsvi]

@MartinHjelmare can you merge the PR? Or are we waiting for another review?

[MartinHjelmare]

We're all good! Changing the PR description doesn't generate a github notification.