Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yeelight nightligh support via separate light entity #26224

Merged
merged 3 commits into from
Sep 6, 2019
Merged

Add yeelight nightligh support via separate light entity #26224

merged 3 commits into from
Sep 6, 2019

Conversation

zewelor
Copy link
Contributor

@zewelor zewelor commented Aug 27, 2019 •
edited
Loading

Description:

Added option to create separate light entity, for better nightlight mode switch UX. By default option is off, its opt in. Redo of #22936

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#10242

Example entry for configuration.yaml (if applicable):

yeelight:
  devices:
    192.168.1.132:
      name: Wall light bedroom
      nightlight_switch_type: light

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

@zewelor zewelor mentioned this pull request Aug 27, 2019
Merged
2 tasks
@zewelor zewelor changed the title Add yheelight nightligh support via separate light entity Add yeelight nightligh support via separate light entity Aug 27, 2019
MartinHjelmare
MartinHjelmare requested changes Aug 31, 2019
View reviewed changes
homeassistant/components/yeelight/light.py Outdated Show resolved Hide resolved
homeassistant/components/yeelight/light.py Outdated Show resolved Hide resolved
@zewelor
Copy link
Contributor Author

zewelor commented Aug 31, 2019

Thanks for code review, both comments fixed.

MartinHjelmare
MartinHjelmare approved these changes Aug 31, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rytilahti ?

rytilahti
rytilahti approved these changes Sep 6, 2019
View reviewed changes
Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! This looks fine for me, but I have no way to test this. However, I trust zewelor knows what he is doing so feel free to merge as you wish.

homeassistant/components/yeelight/light.py Show resolved Hide resolved
@rytilahti rytilahti merged commit c847cc2 into home-assistant:dev Sep 6, 2019
@lock lock bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rytilahti rytilahti rytilahti approved these changes

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed integration: yeelight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zewelor @MartinHjelmare @rytilahti @homeassistant