-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix evohome #26810
Merged
Merged
Bugfix evohome #26810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
integration: evohome
small-pr
PRs with less than 30 lines.
labels
Sep 21, 2019
balloob
reviewed
Sep 25, 2019
balloob
reviewed
Sep 25, 2019
balloob
reviewed
Sep 25, 2019
balloob
reviewed
Sep 25, 2019
balloob
reviewed
Sep 25, 2019
balloob
reviewed
Sep 25, 2019
balloob
reviewed
Sep 25, 2019
@balloob do you have time for another look? |
balloob
approved these changes
Oct 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Device state attributes keys have been changed to snake_case and, since this a breaking change, the opportunity was taken to revise/simplify the entire device state attributes schema.
Description:
evohome is a complicated integration, has had major changes in recent times, and is not yet mature - this PR addresses some bugs and related architectural issues.
set_temperature
to mirror that of the vendor's UI (e.g. any target temp changes until next setpoint, unless explicitly set otherwise)snake_case
for device state attributesunique_id
for each entity (systemId, zoneID, dhwId)Related issue (if applicable): fixes #25985, #25984 (both these, and the above, are related)
Pull request with documentation for home-assistant.io (if applicable): N/A
Example entry for
configuration.yaml
(if applicable): N/AChecklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: