-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump androidtv to 0.0.28 #26906
Merged
MartinHjelmare
merged 4 commits into
home-assistant:dev
from
JeffLIrion:androidtv-adb-shell
Sep 27, 2019
Merged
Bump androidtv to 0.0.28 #26906
MartinHjelmare
merged 4 commits into
home-assistant:dev
from
JeffLIrion:androidtv-adb-shell
Sep 27, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
has-tests
integration: androidtv
small-pr
PRs with less than 30 lines.
labels
Sep 25, 2019
JeffLIrion
force-pushed
the
androidtv-adb-shell
branch
from
September 25, 2019 13:53
8dcc441
to
cb245cb
Compare
JeffLIrion
force-pushed
the
androidtv-adb-shell
branch
from
September 25, 2019 16:34
cb245cb
to
13e92c8
Compare
MartinHjelmare
requested changes
Sep 26, 2019
MartinHjelmare
approved these changes
Sep 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
The failing test seems unrelated to this pull request. |
Seems to be a flaky prometheus test. |
Thanks for the review and for all of your work on Home Assistant, @MartinHjelmare! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Bump
androidtv
to 0.0.28.This updated
androidtv
uses a new package for its Python ADB implementation:adb-shell
, instead ofadb
(technically, a forked version ofadb
with some bug fixes not included in the released version). This accomplishes 2 things:libusb1.so
was not found.libusb1
is a requirement for theadb
package, but not for theadb-shell
package.adb-shell
logs sent and received data at the debug level, which could be used to fix the issue where newer devices don't work with the Python ADB implementation and require the ADB server approach. That said, I don't have one of these newer devices, so I would need someone to help with this.Related issue (if applicable): fixes https://community.home-assistant.io/t/native-support-for-android-tv-android-devices/82792/287
Checklist:
tox
. Your PR cannot be merged unless tests passIf the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
.