Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump androidtv to 0.0.28 #26906

Merged
merged 4 commits into from Sep 27, 2019

Conversation

@JeffLIrion
Copy link
Contributor

commented Sep 25, 2019

Description:

Bump androidtv to 0.0.28.

This updated androidtv uses a new package for its Python ADB implementation: adb-shell, instead of adb (technically, a forked version of adb with some bug fixes not included in the released version). This accomplishes 2 things:

  1. It avoids the issue that some people had where the "check Home Assistant config" add-on told them that there would be an error upgrading to the next version because libusb1.so was not found. libusb1 is a requirement for the adb package, but not for the adb-shell package.
  2. adb-shell logs sent and received data at the debug level, which could be used to fix the issue where newer devices don't work with the Python ADB implementation and require the ADB server approach. That said, I don't have one of these newer devices, so I would need someone to help with this.

Related issue (if applicable): fixes https://community.home-assistant.io/t/native-support-for-android-tv-android-devices/82792/287

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
@project-bot project-bot bot added this to Needs review in Dev Sep 25, 2019
@JeffLIrion JeffLIrion force-pushed the JeffLIrion:androidtv-adb-shell branch from 8dcc441 to cb245cb Sep 25, 2019
@JeffLIrion JeffLIrion force-pushed the JeffLIrion:androidtv-adb-shell branch from cb245cb to 13e92c8 Sep 25, 2019
Dev automation moved this from Needs review to Review in progress Sep 26, 2019
tests/components/androidtv/patchers.py Outdated Show resolved Hide resolved
homeassistant/components/androidtv/media_player.py Outdated Show resolved Hide resolved
@JeffLIrion JeffLIrion closed this Sep 26, 2019
Dev automation moved this from Review in progress to Cancelled Sep 26, 2019
@JeffLIrion JeffLIrion reopened this Sep 26, 2019
Dev automation moved this from Cancelled to Needs review Sep 26, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 26, 2019
Copy link
Member

left a comment

Looks good!

@JeffLIrion JeffLIrion closed this Sep 26, 2019
Dev automation moved this from Reviewer approved to Cancelled Sep 26, 2019
@JeffLIrion JeffLIrion reopened this Sep 26, 2019
Dev automation moved this from Cancelled to Needs review Sep 26, 2019
@JeffLIrion

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2019

The failing test seems unrelated to this pull request.

@JeffLIrion JeffLIrion closed this Sep 26, 2019
Dev automation moved this from Needs review to Cancelled Sep 26, 2019
@JeffLIrion JeffLIrion reopened this Sep 26, 2019
Dev automation moved this from Cancelled to Needs review Sep 26, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

Seems to be a flaky prometheus test.

@MartinHjelmare MartinHjelmare moved this from Needs review to Reviewer approved in Dev Sep 27, 2019
@MartinHjelmare MartinHjelmare merged commit 45c548a into home-assistant:dev Sep 27, 2019
11 checks passed
11 checks passed
CI Build #20190926.38 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.16%)
Details
codecov/project 94.18% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 27, 2019
@JeffLIrion

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2019

Thanks for the review and for all of your work on Home Assistant, @MartinHjelmare!

@lock lock bot locked and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.