Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump androidtv to 0.0.28 #26906

Merged
merged 4 commits into from
Sep 27, 2019

Conversation

JeffLIrion
Copy link
Contributor

Description:

Bump androidtv to 0.0.28.

This updated androidtv uses a new package for its Python ADB implementation: adb-shell, instead of adb (technically, a forked version of adb with some bug fixes not included in the released version). This accomplishes 2 things:

  1. It avoids the issue that some people had where the "check Home Assistant config" add-on told them that there would be an error upgrading to the next version because libusb1.so was not found. libusb1 is a requirement for the adb package, but not for the adb-shell package.
  2. adb-shell logs sent and received data at the debug level, which could be used to fix the issue where newer devices don't work with the Python ADB implementation and require the ADB server approach. That said, I don't have one of these newer devices, so I would need someone to help with this.

Related issue (if applicable): fixes https://community.home-assistant.io/t/native-support-for-android-tv-android-devices/82792/287

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

tests/components/androidtv/patchers.py Outdated Show resolved Hide resolved
homeassistant/components/androidtv/media_player.py Outdated Show resolved Hide resolved
@JeffLIrion JeffLIrion closed this Sep 26, 2019
@JeffLIrion JeffLIrion reopened this Sep 26, 2019
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JeffLIrion JeffLIrion closed this Sep 26, 2019
@JeffLIrion JeffLIrion reopened this Sep 26, 2019
@JeffLIrion
Copy link
Contributor Author

The failing test seems unrelated to this pull request.

@JeffLIrion JeffLIrion closed this Sep 26, 2019
@JeffLIrion JeffLIrion reopened this Sep 26, 2019
@MartinHjelmare
Copy link
Member

Seems to be a flaky prometheus test.

@MartinHjelmare MartinHjelmare merged commit 45c548a into home-assistant:dev Sep 27, 2019
@JeffLIrion
Copy link
Contributor Author

Thanks for the review and for all of your work on Home Assistant, @MartinHjelmare!

@lock lock bot locked and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants