Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validation of device condition config #27131

Merged

Conversation

emontnemery
Copy link
Contributor

Description:

Improve validation of device action config.
This includes condition part from #26830

Improve both when loading at startup, and when an automation is modified through the automation editor UI.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@emontnemery emontnemery force-pushed the device_condition_config_validation branch from dc0ffd3 to d7c4312 Compare October 2, 2019 22:08
@balloob balloob merged commit c43eeee into home-assistant:dev Oct 2, 2019
@emontnemery emontnemery deleted the device_condition_config_validation branch October 3, 2019 16:35
@lock lock bot locked and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants