-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PTZ support to Foscam camera component #27238
Conversation
Hi @skgsergio, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move all the side effects out of the entity init method.
- Move service to foscam domain - Use `dict[key]` for required schema keys or with defaults - Fix sync operations in async context - Remove excessive logging
Addresed all issues and re-tested. Not sure the procedure here, should I squash? |
Moved al initialization to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Can be merged when build passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please exclude homeassistant/components/foscam/const.py
from our test coverage by adding it to .coveragerc
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you for your contribution thus far! 🎖 One final thing: Since this is a significant contribution, we would appreciate you'd added yourself to the list of code owners for this integration. ❤️ Please, add your GitHub username to the For more information about "code owners", see: Architecture Decision Record 0008: Code owners. |
Done 👍 and thank everyone for the project and the awesome help with the PR (next time I'll have the guidelines more clear 😂) |
Well, the opposite is the case: Thank you sir! 🎉 |
Description
This PR extends the current
foscam
component to support PTZ through a service (like theonvif
component).I also took this opportunity to update the module for using the async API.
Pull request with documentation for home-assistant.io: home-assistant/home-assistant.io#10625
Demo
Checklist:
tox
.If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: