Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Assistant Local SDK #27428

Merged
merged 3 commits into from
Oct 13, 2019
Merged

Google Assistant Local SDK #27428

merged 3 commits into from
Oct 13, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Oct 10, 2019

Description:

Add support for the Google Assistant Local SDK messages.

This is superduper alpha. There are a ton of bugs still on Google's side. This is what I have been able to cobble together and got it working. One bug is that your Google Assistant device will restart when it fails to do an HTTP request (ie when you restart Home Assistant).

Also, according to Google engineers that I have been in touch with, some of the things that we're doing are not supposed to work like that. So eh, we'll see. Wanted to get it out there so we can iterate on it.

The zeroconf integration has been updated to make sure that we only start broadcasting when Home Assistant is done starting up. This way we avoid broadcasting Home Assistant without being able to receive HTTP requests.

The JS receiver that runs on Google Assistant devices can be found here: https://github.com/NabuCasa/home-assistant-google-assistant-local-sdk

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (http) you are listed as a codeowner for? Thanks!

@probot-home-assistant
Copy link

Hey there @robbiet480, @Kane610, mind taking a look at this pull request as its been labeled with a integration (zeroconf) you are listed as a codeowner for? Thanks!

@probot-home-assistant
Copy link

Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration (cloud) you are listed as a codeowner for? Thanks!

@probot-home-assistant
Copy link

Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration (google_assistant) you are listed as a codeowner for? Thanks!

@balloob balloob merged commit e866d76 into dev Oct 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the local-google branch October 13, 2019 21:16
@lock lock bot locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants