Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save client identifier from Plex auth for future use #27951

Merged
merged 3 commits into from
Oct 23, 2019

Conversation

jjlawren
Copy link
Contributor

Description:

The client identifier generated during the Plex OAuth-like authentication may be needed in the future to utilize the returned token. The client ID was originally discarded, but this saves it to the config entry in case we need it eventually. No current functionality will break if this requirement is added by Plex, but future component features may need it to be available.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

@balloob balloob merged commit a644182 into home-assistant:dev Oct 23, 2019
@lock lock bot locked and limited conversation to collaborators Oct 24, 2019
@jjlawren jjlawren deleted the plex_save_clientid branch October 26, 2019 14:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants