Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move imports in piglow component #28046

Merged
merged 2 commits into from
Oct 21, 2019
Merged

Move imports in piglow component #28046

merged 2 commits into from
Oct 21, 2019

Conversation

djpremier
Copy link
Contributor

Description:

Moved imports from functions to top-level as requested in #27284

Related issue (if applicable): fixes #27284

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

cgtobi
cgtobi approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@cgtobi cgtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgtobi cgtobi merged commit 4935ef5 into home-assistant:dev Oct 21, 2019
@djpremier djpremier deleted the piglow_fix_imports branch October 22, 2019 21:26
@lock lock bot locked and limited conversation to collaborators Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cgtobi cgtobi cgtobi approved these changes

Assignees
No one assigned
Labels
cla-signed Hacktoberfest integration: piglow small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate integrations to use top-level imports
3 participants
@djpremier @cgtobi @homeassistant