Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit: ship default and full configs #28463

Merged
merged 1 commit into from
Nov 2, 2019
Merged

pre-commit: ship default and full configs #28463

merged 1 commit into from
Nov 2, 2019

Conversation

scop
Copy link
Member

@scop scop commented Nov 2, 2019

Description:

Yet another option for tackling mypy in pre-commit. This is my current favorite. I think we should adopt this one instead of #28405, and also add at least pylint here in the future (leaving that out for now, though).

For now, the only difference between the two is mypy.

It's a bummer that we need to duplicate stuff in the default config in the "all" one, filed RFE about that: pre-commit/pre-commit#1203

Related issue (if applicable): fixes #28283 fixes #28405

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

For now, the only difference between the two is mypy.
@balloob balloob merged commit a8dff2f into home-assistant:dev Nov 2, 2019
@scop scop deleted the pre-commit-configs branch November 2, 2019 19:28
@lock lock bot locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executable mypy not found when using Github desktop
3 participants