Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Huawei LTE empty WiFi host list handling #29130

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Fix Huawei LTE empty WiFi host list handling #29130

merged 1 commit into from
Nov 27, 2019

Conversation

scop
Copy link
Member

@scop scop commented Nov 27, 2019

Description:

Fixes an issue with an empty WiFi clients listing with some router models and scenarios.

The issue essentially makes the integration inoperable in affected setups, so a point release with this would be welcome. Not sure what's the proper way to ask it.

https://github.com/Salamek/huawei-lte-api/releases/tag/1.4.4

Related issue (if applicable): fixes #28922

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob merged commit 5bc8ef9 into home-assistant:dev Nov 27, 2019
@lock lock bot locked and limited conversation to collaborators Nov 28, 2019
@scop scop deleted the upgrade-huawei-lte branch November 28, 2019 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Huawei LTE integration doesn't find entities
3 participants