Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort imports according to PEP8 for gpslogger #29717

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

basnijholt
Copy link
Contributor

Description:

I have sorted the imports for the gpslogger component according to PEP8 using isort.

I think it would be good if in the future we can add isort to the .pre-commit-config.yaml.
To do that I will first fix all sorting issues per component.

Black and isort do not play nice by default, however, using the following .isort.cfg config:

[settings]
multi_line_output=3
include_trailing_comma=True
force_grid_wrap=0
use_parentheses=True
line_length=88

it works.

This PR affects:

  • homeassistant/components/gpslogger/__init__.py
  • homeassistant/components/gpslogger/config_flow.py
  • homeassistant/components/gpslogger/device_tracker.py

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@frenck frenck changed the title sort imports according to PEP8 for gpslogger Sort imports according to PEP8 for gpslogger Dec 9, 2019
@frenck frenck merged commit ebb2722 into home-assistant:dev Dec 9, 2019
@lock lock bot locked and limited conversation to collaborators Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants