New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add battery sensor to iCloud #29818
Add battery sensor to iCloud #29818
Conversation
4d36ea5
to
a3fa8fe
Compare
0f565ea
to
c61d7f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to use the builtin update interval or should we connect a state update to the dispatch helper signal, for the sensor?
I think that would be better with a dispatch signal, it’s gonna avoid the 30s default and when iCloud interval is 1 min sensors are updated in HA for 1 min 30 actually. Will look into it. |
We can also look into it at the next PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final comment.
Can be merged when build passes. |
build passes 😊 |
I've just added the dispatch signal in this PR #30680 |
Breaking Change:
None, addition
Description:
Follows #28968
Add battery sensor for each iDevice of your account.
Pull request with documentation for home-assistant.io : home-assistant/home-assistant.io#11434
iCloud device list
iCloud device details
Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.