Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example value for Todoist service #29953

Merged
merged 1 commit into from
Dec 15, 2019
Merged

Conversation

boralyl
Copy link
Contributor

@boralyl boralyl commented Dec 15, 2019

Description:

This PR fixes the example value for the todoist new_task service. Something in homeassistant changed between 0.102.3 and 0.103.0 that now parses the due_date as a datetime.date instead of a str. Quotes are now uses to ensure it gets parsed as a str.

This caused the homeassistant.components.websocket_api component to not be able to serialize the service ( example error). This unfortunately completely breaks the UI and the only way to get around it is to remove the component from configuration.yaml

Related issue (if applicable): fixes #29876

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label Dec 15, 2019
@MartinHjelmare MartinHjelmare changed the title Fixes example value for todoist service. Fix example value for todoist service Dec 15, 2019
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @boralyl! 👍

@frenck frenck changed the title Fix example value for todoist service Fix example value for Todoist service Dec 15, 2019
@frenck frenck merged commit 012c09c into home-assistant:dev Dec 15, 2019
@lock lock bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.103.0 Todoist Component Broken
3 participants