Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirements from image_processing #30113

Merged
merged 1 commit into from Dec 22, 2019
Merged

Remove requirements from image_processing #30113

merged 1 commit into from Dec 22, 2019

Conversation

@balloob
Copy link
Member

balloob commented Dec 21, 2019

Description:

The image processing integration contained a utility function that caused it to have a requirement. This is not good as image processing is an entity integration and is thus imported by other integrations that expose Home Assistant to other systems. Now all of a system they all had to install this requirement.

I moved the utility function to util.pil and updated all integrations that used it.

Related issue (if applicable): partial fix for #29845

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
@balloob balloob requested a review from home-assistant/core as a code owner Dec 21, 2019
@project-bot project-bot bot added this to Needs review in Dev Dec 21, 2019
@balloob balloob changed the title Remove requirement from entity integration Remove requirements from image_processing Dec 21, 2019
@balloob balloob merged commit 32aae70 into dev Dec 22, 2019
9 checks passed
9 checks passed
CI Build #20191221.16 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.
Dev automation moved this from Needs review to Done Dec 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the image-processing-pil branch Dec 22, 2019
@balloob balloob added this to the 0.103.4 milestone Dec 22, 2019
balloob added a commit that referenced this pull request Dec 22, 2019
@balloob balloob mentioned this pull request Dec 22, 2019
@lock lock bot locked and limited conversation to collaborators Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
2 participants
You can’t perform that action at this time.