Remove requirements from image_processing #30113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
changed the title
balloob
added a commit
that referenced
this pull request
Dec 22, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The image processing integration contained a utility function that caused it to have a requirement. This is not good as image processing is an entity integration and is thus imported by other integrations that expose Home Assistant to other systems. Now all of a system they all had to install this requirement.
I moved the utility function to
util.piland updated all integrations that used it.Related issue (if applicable): partial fix for #29845
Checklist:
tox. Your PR cannot be merged unless tests pass