Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken setup of logbook integration #30137

Merged
merged 1 commit into from Dec 22, 2019
Merged

Conversation

@springstan
Copy link
Member

springstan commented Dec 22, 2019

Description:

Related issue (if applicable): fixes #29845

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@project-bot project-bot bot added this to Needs review in Dev Dec 22, 2019
Dev automation moved this from Needs review to Reviewer approved Dec 22, 2019
@balloob balloob merged commit 2518088 into home-assistant:dev Dec 22, 2019
7 of 9 checks passed
7 of 9 checks passed
CI Build #20191222.4 had test failures
Details
CI (Tests PyTest Python37) Tests PyTest Python37 failed
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Dec 22, 2019
@balloob

This comment has been minimized.

Copy link
Member

balloob commented Dec 22, 2019

argh this was the wrong fix. We should do it inside logbook 🤦‍♂

@balloob

This comment has been minimized.

Copy link
Member

balloob commented Dec 22, 2019

So logbook needs to get a way for other integrations to allow registering events they want processed. This is a stopgap measure for now.

@balloob

This comment has been minimized.

Copy link
Member

balloob commented Dec 22, 2019

We should do it with the new helpers.integration_platform helper.

@balloob balloob added this to the 0.103.4 milestone Dec 22, 2019
balloob added a commit that referenced this pull request Dec 22, 2019
@balloob balloob mentioned this pull request Dec 22, 2019
@lock lock bot locked and limited conversation to collaborators Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.