Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken setup of logbook integration #30137

Merged
merged 1 commit into from Dec 22, 2019
Merged

Fix broken setup of logbook integration #30137

merged 1 commit into from Dec 22, 2019

Conversation

springstan
Copy link
Member

Description:

Related issue (if applicable): fixes #29845

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@probot-home-assistant probot-home-assistant bot added integration: homekit small-pr PRs with less than 30 lines. labels Dec 22, 2019
@project-bot project-bot bot added this to Needs review in Dev Dec 22, 2019
Dev automation moved this from Needs review to Reviewer approved Dec 22, 2019
@balloob balloob merged commit 2518088 into home-assistant:dev Dec 22, 2019
Dev automation moved this from Reviewer approved to Done Dec 22, 2019
@balloob
Copy link
Member

balloob commented Dec 22, 2019

argh this was the wrong fix. We should do it inside logbook 🤦‍♂

@balloob
Copy link
Member

balloob commented Dec 22, 2019

So logbook needs to get a way for other integrations to allow registering events they want processed. This is a stopgap measure for now.

@balloob
Copy link
Member

balloob commented Dec 22, 2019

We should do it with the new helpers.integration_platform helper.

@balloob balloob added this to the 0.103.4 milestone Dec 22, 2019
balloob pushed a commit that referenced this pull request Dec 22, 2019
@springstan @balloob
Move imports into setup function in homekit __init__.py (#30137)
e74c4c5
@balloob balloob mentioned this pull request Dec 22, 2019
Merged
@lock lock bot locked and limited conversation to collaborators Dec 23, 2019
@springstan springstan deleted the logbook-fix branch April 7, 2020 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed integration: homekit small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
0.103.4
Development

Successfully merging this pull request may close these issues.

Logbook component broken after 72f336a (bisected)
3 participants
@springstan @balloob @homeassistant