Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Axis - Improve tests based on feedback #30430

Merged
merged 2 commits into from
Jan 3, 2020
Merged

Axis - Improve tests based on feedback #30430

merged 2 commits into from
Jan 3, 2020

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Jan 3, 2020

Breaking Change:

Description:

Use MockConfigEntry, add_to_hass and hass.config_entries.async_setup

Related issue (if applicable): fixes comments from #30415

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@Kane610 Kane610 self-assigned this Jan 3, 2020
@probot-home-assistant probot-home-assistant bot added has-tests small-pr PRs with less than 30 lines. labels Jan 3, 2020
@Kane610 Kane610 mentioned this pull request Jan 3, 2020
Merged
4 tasks
@Kane610
Copy link
Member Author

Kane610 commented Jan 3, 2020

@MartinHjelmare OK like this?

MartinHjelmare
MartinHjelmare approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare merged commit b57da2f into home-assistant:dev Jan 3, 2020
@Kane610 Kane610 deleted the axis-improve_tests_fix_comments branch January 3, 2020 12:36
@lock lock bot locked and limited conversation to collaborators Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@Kane610 Kane610

Labels
cla-signed has-tests small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kane610 @MartinHjelmare @homeassistant