Change nomenclature for Roborock fan speeds #30614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Breaking Change: May break some automations using the string/names from the current implementation. > Users will need to update any automations that utilize fan speed values – specifically: > > * `Quiet -> Silent` > > * `Balanced -> Standard` > > * `Turbo -> Medium` > > * `Max -> Turbo` ## Description: Those are the new fan speed nomenclatures on the Xiaomi app vs 5.6.34. **Pull request with documentation for [home-assistant.io](https://github.com/home-assistant/home-assistant.io) (if applicable):** home-assistant/home-assistant.io#11523 ## Example entry for `configuration.yaml` (if applicable): Not applicable. ## Checklist: - [X] The code change is tested and works locally. - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass** - [X] There is no commented out code in this PR. - [X] I have followed the [development checklist][dev-checklist] If user exposed functionality or configuration variables are added/changed: - [X] Documentation added/updated in [home-assistant.io](https://github.com/home-assistant/home-assistant.io) If the code communicates with devices, web services, or third-party tools: - [x] [_The manifest file_][manifest-docs] has all fields filled out correctly. Update and include derived files by running `python3 -m script.hassfest`. - [x] New or updated dependencies have been added to `requirements_all.txt` by running `python3 -m script.gen_requirements_all`. - [x] Untested files have been added to `.coveragerc`. If the code does not interact with devices: - [x] Tests have been added to verify that the new code works. [dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html [manifest-docs]: https://developers.home-assistant.io/docs/en/creating_integration_manifest.html
probot-home-assistant
bot
added
integration: xiaomi_miio
small-pr
|
Hey there @rytilahti, @syssi, mind taking a look at this pull request as its been labeled with a integration ( |
9 tasks
|
@tiagofreire-pt please adjust the tests accordingly to this change :) |
9 tasks
springstan
approved these changes
Jan 9, 2020
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing the previous PR #30164, because some weird errors rebasing my repo.
Breaking Change:
This change adjusts some fan speed values according to the Xiaomi app version 5.6.34. and therefore users will need to update anything that utilizes the following fan speed values:
Quiet->SilentBalanced->StandardTurbo->MediumMax->TurboDescription:
Those are the new fan speed nomenclatures on the Xiaomi app vs 5.6.34.
Pull request with documentation for home-assistant.io (if applicable):
home-assistant/home-assistant.io#11523
Example entry for
configuration.yaml(if applicable):Not applicable.
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: