Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit of measure for withings hydration #30685

Merged
merged 1 commit into from
Jan 12, 2020
Merged

Fix unit of measure for withings hydration #30685

merged 1 commit into from
Jan 12, 2020

Conversation

vangorra
Copy link
Contributor

Breaking Change:

None

Description:

Fixing unit of measure for withings hydration.

Related issue (if applicable): fixes #30570

Pull request with documentation for home-assistant.io (if applicable): None

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@MartinHjelmare MartinHjelmare changed the title Fixing unit of measure for withings hydration. Fix unit of measure for withings hydration Jan 11, 2020
Copy link
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Adminiuga Adminiuga merged commit 672db9c into home-assistant:dev Jan 12, 2020
@vangorra vangorra deleted the vangorra_withings_hydration branch January 12, 2020 03:08
@lock lock bot locked and limited conversation to collaborators Jan 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Withings data formatting and missing data
3 participants